[Bug 796772] waylandsink: check for wl_shell unneeded when surface and display are passed by the application
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Jul 11 00:10:58 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=796772
--- Comment #4 from Matteo Valdina <matteo.valdina at gmail.com> ---
> I'm also wondering, why not add support for the scenario instead, so that
> gst-launch works without wl_shell ?
The point of relaxing the wl_shell constrains is to allow the application to
run in a Wayland compositor that is not providing wl_shell (for example
fullscreen-shell) and let the application to deal with it.
In this way the application developer can use waylandsink in other wayland
compositor or custom compositor.
I know that there are couples of shells that likes wl_shell, for example,
fullscreen_shell, xdg_shell, and ivi_shell.
This is different from adding the support of fullscreen_shell that it is more
for gst-launch or simpler application.
Anyway, the support of fullscreen_shell is an easy task. I'll try to wrap-up a
patch for that.
About the corner case for wl_shell I see that the error condition is handled
like a failure of wl_shell_surface.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list