[Bug 796519] Add AV1 codec parser

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Jul 11 03:48:34 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796519

--- Comment #18 from XuGuangxin <guangxin.xu at intel.com> ---
+struct _GstAV1Parser {
+  struct {
+    guint8 SeenFrameHeader;
+    guint8 temporal_id;
+    guint8 spatial_id;
+    guint64 obu_start_position;
+    GstAV1Size obu_size;
+    GstAV1OBUType obu_type;
+  } state;
+
+  GstAV1ReferenceFrameInfo ref_info;
+    //References
+  GstAV1SequenceHeaderOBU *seq_header;
+  GstAV1FrameHeaderOBU *frame_header;
+};
+

I have a concern about this. The temproal_id, frame_header may only be related
to one frame, why we put this in parser? 
I suggest we follow some logic like this
1. If some information only applied in on a frame we can put it to FrameHeader.
2. If some information applied to multi frame
       if caller need knows this information, we can put it to the public.
       if the caller does not need to know this information, we can put it to a
private c file
thanks

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list