[Bug 792131] rtspsrc: add an action signal to send SET_PARAMETER

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792131

--- Comment #11 from ulfo at axis.com ---
(In reply to Sebastian Dröge (slomo) from comment #10)
> (In reply to ulfo from comment #9)
> 
> > Thank you for your feedback. I have fixed most of the comments but I'm still
> > a  bit uncertain how to best handle gst_rtspsrc_loop_end_cmd in 
> > gst_rtspsrc_get_parameter and gst_rtspsrc_set_parameter.
> 
> What do you mean exactly?

<@@ +5796,3 @@
<+      break;
<+    case CMD_SET_PARAMETER:
<+      GST_ELEMENT_PROGRESS (src, ERROR, "request", ("SET_PARAMETER failed"));
<
<And these should probably get some kind of error response on the promise?

It was this comment that triggered it. For an example the call sequence to
gst_rtspsrc_loop_error_cmd is

gst_rtspsrc_set_parameter -> gst_rtspsrc_loop_end_cmd ->
gst_rtspsrc_loop_error_cmd

and I have already an active request so then I have to pass the request to
gst_rtspsrc_loop_end_cmd like

if (async && res != GST_RTSP_OK)
      gst_rtspsrc_loop_end_cmd (src, CMD_SET_PARAMETER, res, req);

Well that is one way to do it

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.