[Bug 796794] flowcombiner: update_pad_flow should check that the pad is inside the combiner

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796794

--- Comment #5 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Created attachment 373002
  --> https://bugzilla.gnome.org/attachment.cgi?id=373002&action=edit
patch 2/2

(In reply to Xabier Rodríguez Calvar from comment #4)
> (In reply to Tim-Philipp Müller from comment #2)
> > I wonder if we can do something smarter here? Iterating the list twice for
> > each flow combination just for a sanity check seems potentially expensive
> > and unnecessary to me. Might not matter if it's just a few pads of course,
> > but..
> 
> I don't know how we could do this. Maybe passing the pad thru down to
> gst_flow_combiner_get_flow but we might be running some other code
> in-between and bail out before we reach that check.

In my second patch (that would apply on top of the first) I create the unsafe
version that avoids the check.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.