[Bug 796692] sample/bufferlist/buffer: Non-writable container miniobjects allow writable access to their contents, causing memory problems

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796692

--- Comment #46 from Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> ---
Created attachment 373011
  --> https://bugzilla.gnome.org/attachment.cgi?id=373011&action=edit
v4l2bufferpool: Remove duplicate check

We were calling gst_v4l2_is_buffer_valid() before and inside
gst_v4l2_buffer_pool_qbuf() as we needed to access the group. The second
check failed since the writability of the buffer get inherited from the
GstMemory, which lead to pipeline failure. As we cannot avoid the extra
ref, it would be racy otherwise, just pass the group to _dbuf() so it
does not have to call gst_v4l2_is_buffer_valid() again.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.