[Bug 796801] find_codec_preferences: use received caps

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jul 12 19:23:34 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796801

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373009|none                        |reviewed
             status|                            |

--- Comment #2 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 373009:
 --> (https://bugzilla.gnome.org/review?bug=796801&attachment=373009)

Makes sense but I think the commit message doesn't explain so well the issue
:-)

::: ext/webrtc/gstwebrtcbin.c
@@ +1264,3 @@
+      if (pad->received_caps) {
+        caps = gst_caps_ref (pad->received_caps);
+      } else if ((caps = gst_pad_get_current_caps (GST_PAD (pad)))) {

Is that still needed now that you use the "cache" caps?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list