[Bug 796801] find_codec_preferences: use received caps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796801

Mathieu Duponchelle <mduponchelle1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373009|reviewed                    |none
             status|                            |
 Attachment #373009|0                           |1
        is obsolete|                            |

--- Comment #3 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
Created attachment 373012
  --> https://bugzilla.gnome.org/attachment.cgi?id=373012&action=edit
find_codec_preferences: use received caps

When negotiation is triggered by receiving caps on our sink pad
probes, we could encounter a race condition where need-negotiation
is emitted and the application requires the creation of an offer
before the current caps were actually updated.

This led to retrieving incomplete caps when creating the offer,
using find_codec_preferences -> pad_get_current_caps.

Instead, as we save the caps in the probe callback anyway, it is better
and thread safe to use these if they were set.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.