[Bug 796810] webrtc SDP RTX processing bug with no ssrc

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Jul 15 13:09:18 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796810

--- Comment #1 from Jan Schmidt <thaytan at noraisin.net> ---
The lack of ssrc in the caps is the unit test's fault. Adding ssrc there makes
the warning go away. I'm not sure if webrtcbin should do something more in this
case - not try to generate the RTX info perhaps?

Pushed 2 commits to fix the unit test and at least not use uninitialised memory
if ssrc isn't available:

commit 0af199e25ec7732c7a8462bae4e62219badb313c (HEAD -> master)
Author: Jan Schmidt <jan at centricular.com>
Date:   Sun Jul 15 23:05:26 2018 +1000

    webrtc: Add some ssrc to caps in the unit test.

    The unit test uses incomplete caps to test webrtcbin,
    causing some weirdness generating RTX stream mappings.

    https://bugzilla.gnome.org/show_bug.cgi?id=796810

commit e6a564216d9adabf11e99a1cdbe6c20545d1dd57
Author: Jan Schmidt <jan at centricular.com>
Date:   Sat Jul 14 23:15:02 2018 +1000

    webrtc: Add a warning in sdp_media_from_transceiver()

    When generating caps with no ssrc, at least throw a
    warning instead of using an uninitialised stack variable

    https://bugzilla.gnome.org/show_bug.cgi?id=796810

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list