[Bug 640610] basesink: QoS events are wrong in live pipelines

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jul 16 17:08:59 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=640610

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #37 from Olivier Crête <olivier.crete at ocrete.ca> ---
I didn't realize how exactly the latency code worked in basesink, I've fixed it
now...

The reason is I pushed the change to basesink for everyone is so that pipelines
like udpsrc ! videodecoder ! udpsink, because before this fix, those pipelines
end up dropping all packets unless QoS is involved.

I've also added some unit tests for the processing-deadline:

commit 4f3aea316acd38ce498dd7130db76e91a76490d7
Author: Olivier Crête <olivier.crete at collabora.com>
Date:   Mon Jul 16 11:51:05 2018 -0400

    sink: Only add processing latency if upstream is live

    Only add it if upstream is live, otherwise leave the latency at 0.

    https://bugzilla.gnome.org/show_bug.cgi?id=640610

commit f79b871a6a400c411313eb82a71b3a3475c0ac99
Author: Olivier Crête <olivier.crete at collabora.com>
Date:   Mon Jul 16 11:50:36 2018 -0400

    pipeline tests: Add test for processing latency

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list