[Bug 796818] deinterlace: Timecode pass-through

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796818

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373074|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373074:
 --> (https://bugzilla.gnome.org/review?bug=796818&attachment=373074)

Looks good except for

::: gst/deinterlace/gstdeinterlace.c
@@ +1130,3 @@
     self->field_history[i].flags =
         self->field_history[i - fields_to_push].flags;
+    self->field_history[i].tc = self->field_history[i - fields_to_push].tc;

You're overriding old timecodes here without freeing them

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.