[Bug 796835] srtpdec: remove bogus check that accesses uninitialized memory

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796835

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373092|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373092:
 --> (https://bugzilla.gnome.org/review?bug=796835&attachment=373092)

::: ext/srtp/gstsrtpdec.c
@@ +565,3 @@
   }

+  if (gst_structure_get (s, "srtp-key", GST_TYPE_BUFFER, &buf, NULL)) {

Someone could set a NULL buffer in here, that's probably what this wanted to
guard against? The better solution would be to initialize it to NULL first.

Also is there the same pattern used for the SRTCP key elsewhere?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.