[Bug 796832] vaapih264dec: Does not always recover from data lost

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796832

--- Comment #9 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #3)
> Review of attachment 373088 [details] [review]:
> 
> ::: gst-libs/gst/vaapi/gstvaapidecoder_h264.c
> @@ +4482,3 @@
>      if (priv->stream_alignment == GST_VAAPI_STREAM_ALIGN_H264_NALU) {
>        buf_size = size;
> +      if (size > 4)
> 
> I guess the patch would be simpler if, above, in line 4479 we change
> 
> -    if (size < 4)
> +    if (size =< 4) 
>        return GST_VAAPI_DECODER_STATUS_ERROR_NO_DATA
> 

Correction: It is legal to have nal units of size 4, eg: end of stream and end
of sequece nals.

> which works for both stream alignments

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.