[Bug 796843] srtserversink: Do not post error message during stopping

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796843

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olivier.crete at ocrete.ca

--- Comment #5 from Olivier Crête <olivier.crete at ocrete.ca> ---
(In reply to Seungha Yang from comment #4)
> Review of attachment 373102 [details] [review]:
> 
> ::: ext/srt/gstsrtserversink.c
> @@ +219,2 @@
>        GST_DEBUG_OBJECT (self, "Cancelled waiting for client");
>        ret = FALSE;
> 
> What was the exact expected behavior in here?
> 
> For some reasons, basesink::unlock() && basesink::unlock_stop() can be
> called and
> then, this GSource callback function could be returned with "FALSE" 
> (if my understanding is correct, then this callback will not be called again)
> 
> But there seems no code for re- attaching GSource. Do I missing something?

I think the unlock/unlock_stop() shouldn't be used here.. instead it should
just stop the thread in the _stop() vfunc like you added. unlock/unlock_stop()
are normally for the case where it can block in the _render() vfunc. But here
we jut create a new thread where blocking happens.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.