[Bug 796776] zlib compile failed for Android (regression )

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796776

Nirbheek Chauhan <nirbheek.chauhan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.15.1

--- Comment #4 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
(In reply to Jan Schmidt from comment #3)
> Confirming that the android build is broken in git master as at
> 056e448d6a25ebf0d8af71978172d91054b730d4
> 
> Adding
> 
> os.environ['WINDRES']= ""
>

Fixed with: 

commit ce2d54e7c42afd1147788a7ba8bdaed5efa3cbd9 (centricular/wip/meson)
Author: Nirbheek Chauhan <nirbheek at centricular.com>
Date:   Thu Jul 19 12:09:27 2018 +0530

    cerbero: Don't set old env to None for unset env vars

    It's wrong (unset != None) and causes a traceback:


> to config/android.cbc gets past the first error, but breaks building glib
> because the values assigned to CFLAGS in the recipe don't get passed to the
> cross compiler values - in particular not having '-DNVALGRIND=1' doesn't
> compile, but the GIO settings are also probably important.
> 
> Adding -DNVALGRIND=1 to the c_args fixes the first part of that.
> 

Fixed with:

commit 7462b0655e714a11e4edb1e0c3ef72c74556c4e8
Author: Nirbheek Chauhan <nirbheek at centricular.com>
Date:   Sat Jul 21 11:37:33 2018 +0530

    cerbero: Rework environment modification in recipes


> Beyond that, zlib and glib are building dynamic libs, not static ones. The
> output won't be useful.

Fixed with:

commit 9c69d11a5f7cef961d9e90bdaab2a0cce758ec6a
Author: Nirbheek Chauhan <nirbheek at centricular.com>
Date:   Thu Jul 19 13:50:15 2018 +0530

    cerbero: Build both static and shared with Meson

    Also, detect if someone tries to set `default_library` in
    self.meson_options, and error out before configure. You should set
    self.meson_default_library instead.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.