[Bug 796833] gl: Add configuration switches for turning on/off features with external dependencies

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Jul 22 02:53:15 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796833

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373090|none                        |needs-work
             status|                            |

--- Comment #3 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 373090:
 --> (https://bugzilla.gnome.org/review?bug=796833&attachment=373090)

Not quite :)

::: m4/gst-gl.m4
@@ +182,3 @@
     fi

+    if test "x$HAVE_EGL" = "xyes" -a "x$NEED_GBM" != "xno"; then

This condition needs to be reversed and separated to ask if gbm was explicitly
asked for and then error out if EGL wasn't found or was disabled.  i.e.
--enable-gbm --disable-egl should error.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list