[Bug 796846] compositor: Use 255 as maximum alpha instead of 256

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796846

--- Comment #3 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 373108:
 --> (https://bugzilla.gnome.org/review?bug=796846&attachment=373108)

Looks good to me, except:

::: gst/compositor/blend.c
@@ +34,3 @@
 #include <gst/video/video.h>

+#define BLEND(D,S,alpha) (((D) * (255 - (alpha)) + (S) * (alpha)) >> 8)

If your multiplier here is 255, you should divide by 255, not 256.

On 2nd look though, this macro isn't used anywhere and can just be deleted.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.