[Bug 795330] pad: Handle changing sticky events in pad probes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795330

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 371042:
 --> (https://bugzilla.gnome.org/review?bug=795330&attachment=371042)

::: gst/gstpad.c
@@ +5268,1 @@
     GstPadProbeType type)

This new signature makes not much sense ownership-wise. It takes ownership of
the passed event, might replace the event with a new one, and then gives back
the (possibly changed) event at the end if all succeeded but in none of the
early exits. And the caller does not own the returned event, it might even be
destroyed already (if it was changed and make_writable() created a new event).

And that's exactly the problem here, you might then store a newly created event
that you don't own in ev->event (and leaked the original one there).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.