[Bug 795330] pad: Handle changing sticky events in pad probes

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jul 23 17:03:24 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=795330

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 371042:
 --> (https://bugzilla.gnome.org/review?bug=795330&attachment=371042)

::: tests/check/gst/gstpad.c
@@ +3327,3 @@
+
+  srcpad = gst_element_get_static_pad (harness->element, "src");
+  stream_start = gst_pad_get_sticky_event (srcpad, GST_EVENT_STREAM_START, 0);

Basically this event should've never been changed. It's inside the fakesrc,
it's before your pad probe has ever seen it and your pad probe should not
change the event upstream of the probe.

Interestingly this problem is very similar to the ownership problem in the
changed send_event(), that probably tells us something :) You want to change
something that is stored "before you" and where you don't own the storage.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list