[Bug 795330] pad: Handle changing sticky events in pad probes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795330

--- Comment #13 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Sebastian Dröge (slomo) from comment #12)
> (In reply to Thibault Saunier from comment #11)
> > Review of attachment 371042 [details] [review] [review]:
> > 
> > ::: tests/check/gst/gstpad.c
> > @@ +3327,3 @@
> > +
> > +  srcpad = gst_element_get_static_pad (harness->element, "src");
> > +  stream_start = gst_pad_get_sticky_event (srcpad, GST_EVENT_STREAM_START,
> > 0);
> > 
> > I understand what you mean but what you describe is broken to me as if for
> > some reason the sticky event is pushed again (unsticked), it will push the
> > wrong version of what dowstream should receive, which was exactly my problem
> > here iirc.
> 
> Why would it receive the wrong version? Your pad probe would replace the
> event again in the same way

In the testcase yes, in the real world example it was not the case as the probe
was removed, and without that patch I believe that the STREAM_START was
unsticked before each buffer or something like that (I do not have that code
anymore so my memory might be wrong and note that I do not need that patch
anymore as I reworked the whole thing)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.