[Bug 795330] pad: Handle changing sticky events in pad probes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795330

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #21 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
commit 2aa9ad9c62d3071c90e837bc8a5923b6f16d7fcd (HEAD -> master, origin/master,
origin/HEAD)
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Mon Jul 23 23:17:54 2018 +0300

    Revert "pad: Handle changing sticky events in pad probes"

    This reverts commit 11e0f451eb498e92d05d8208f7217625dc62848b.

    When pushing a sticky event out of a pad with a pad probe or pad offset,
    those should not be applied to the event that is actually stored in the
    event but only in the event sent downstream. The pad probe and pad
    offsets are conceptually *after* the pad, added by external code and
    should not affect any internal state of pads/elements.

    Also storing the modified event has the side-effect that a re-sent event
    would arrive with any previous modifications done by the same pad probe
    again inside that pad probe, and it would have to check if its
    modifications are already applied or not.

    For sink pads and generally for events arriving in a pad, some further
    changes are still needed and those are tracked in
      https://bugzilla.gnome.org/show_bug.cgi?id=765049

    In addition, the commit also had a refcounting problem with events,
    causing already destroyed events to be stored inside pads.

*** This bug has been marked as a duplicate of bug 765049 ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.