[Bug 796836] avwait: Add recording property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796836

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373125|none                        |needs-work
             status|                            |

--- Comment #14 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373125:
 --> (https://bugzilla.gnome.org/review?bug=796836&attachment=373125)

Seems fine except for a couple of similar memory problems when running the test
in valgrind.

E.g. in line 741 you unref the buffer, but from previously in line 731 you
still have a reference to the timecode stored in its meta (which is invalid
now) and you use the timecode (that is now freed) in line 758. It's an old
problem but thanks to the test this shows up now.

It seems to be the only problem reported for the test, just a couple of dozen
times.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.