[Bug 796860] short mp4 file eos event leaks

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796860

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
 Attachment #373132|none                        |reviewed
             status|                            |

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 373132
  --> https://bugzilla.gnome.org/attachment.cgi?id=373132
proposed patch

Thanks for the patch!

Not sure this is entirely right.

I think we only need to unref the event if the return value is
GST_PAD_PROBE_HANDLED, but there seems to be at least one code path where it's
going to be GST_PAD_PROBE_REMOVE and I think if we return REMOVE we mustn't
unref the event?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.