[Bug 796865] typefind: Add _with_extension() variants for typefinding data or a buffer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796865

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373146|none                        |reviewed
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 373146
  --> https://bugzilla.gnome.org/attachment.cgi?id=373146
typefind: Add _with_extension() variants for typefinding data or a buffer

>+static GList *
>+sort_list_by_extension (GstObject * obj, GList * type_list,
>+    const gchar * extension)

I would prefer a different name for this function if we can come up with one,
as we don't really sort by extension (which we definitely don't want to do), we
just massage the list as to move any matching typefinders to the front :)

>+/**
>+ * gst_type_find_helper_for_data_with_extension:
>+ * @obj: (allow-none): object doing the typefinding, or %NULL (used for logging)
>+ * @data: (transfer none) (array length=size): * a pointer with data to typefind
>+ * @size: the size of @data
>+ * @extension: extension of the media

Missing nullable or allow-none, whichever it is these days, plus comment that
%NULL is allowed.


>+/**
>+ * gst_type_find_helper_for_buffer_with_extension:
>+ * @obj: (allow-none): object doing the typefinding, or %NULL (used for logging)
>+ * @buf: (in) (transfer none): a #GstBuffer with data to typefind
>+ * @prob: (out) (allow-none): location to store the probability of the found
>+ *     caps, or %NULL

@extension: is missing.

Otherwise looks good to me. Not sure why we did this only for pull mode in the
first place.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.