[Bug 796832] vaapih264dec: Does not always recover from data lost

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796832

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373148|none                        |reviewed
             status|                            |

--- Comment #16 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 373148:
 --> (https://bugzilla.gnome.org/review?bug=796832&attachment=373148)

::: gst/vaapi/gstvaapidecode.c
@@ +1089,3 @@

+  /* Disable errors on decode errors */
+  gst_video_decoder_set_max_errors (vdec, -1);

I don't know. It doesn't feel right.

What options do we have?

1. replacing those wrong GST_VIDEO_DECODER_ERROR() with other way to handling
the error
2. disable the errors only if upstream is live

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.