[Bug 795107] Meson: missing option to enable/disable plugins

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Jul 25 14:16:28 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=795107

--- Comment #42 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
(In reply to Xavier Claessens from comment #39)
> Review of attachment 373153 [details] [review]:
> 
> ::: gst/meson.build
> @@ +6,3 @@
> +    subdir(plugin)
> +  endif
> +endforeach
> 
> As per earlier discussion in this bug, we prefer to keep all subdir() calls
> and inside the plugin's meson.build do
> 
> if get_option('foo').disabled()
>   subdir_done()
> endif

The `foreach` mechanism in that patch seems much more elegant and
self-contained to me than adding `subdir_done()` separately for each plugin.
It's also much less churn.

Adding a new plugin subdir will automatically associate it with an option, and
the build system will immediately complain if you forget to define it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list