[Bug 795107] Meson: missing option to enable/disable plugins

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795107

--- Comment #48 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
(In reply to Tim-Philipp Müller from comment #45)
> We should prepare an MR for gnome-continuous before the gtk_doc change lands
> and let ebassi know in advance:
> https://gitlab.gnome.org/GNOME/gnome-continuous/blob/master/manifest.
> json#L689

It looks like continuous is already broken, and is chugging along because Meson
ignores unknown option arguments. We should fix it, but it shouldn't block
these patches.

(In reply to Tim-Philipp Müller from comment #46)
> Comment on attachment 373153 [details] [review]
> Feature options for gst-plugins-base.
> 
> >+# Examples-only feature options
> >+option('gdk-pixbuf', type : 'feature', value : 'auto', description : 'GDK-PixBuf support in examples')
> >+option('gtk3', type : 'feature', value : 'auto', description : 'GTK+ 3 support in examples')
> >+option('qt5', type : 'feature', value : 'auto', description : 'Qt5 support in examples')
> >+option('sdl1', type : 'feature', value : 'auto', description : 'SDL 1.2 support in examples')
> 
> Not sure if this is really needed, it's certainly more than we provide now
> and no one ever asked for this as far as  I recall. Wouldn't a simple
> "examples" option be sufficient?
> 

Yes, I realized when I looked at -bad that this doesn't scale nor does it make
sense. I will put it behind the examples option instead.

(In reply to Tim-Philipp Müller from comment #47)
> Comment on attachment 373154 [details] [review]
> Feature options for gst-plugins-good
> 
> > # Common options
> >+option('examples', type : 'boolean', value : true, yield : true)
> 
> Wonder if this should be a feature as well and default to auto?
> 
> (Even if we don't have a way to pass arrays of features to required:)

Let me have a crack at that and see how it looks, but yes it does make sense to
do this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.