[Bug 796875] rtsp-client: always allocate both IPV4 and IPV6 sockets

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796875

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373163|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373163:
 --> (https://bugzilla.gnome.org/review?bug=796875&attachment=373163)

::: gst/rtsp-server/rtsp-client.c
@@ +1880,1 @@
             use_client_settings))

Does this make use of the address pool properly? It might be that there are
only v4 or v6 addresses in the pool, then allocation of the other would fail
here and we should probably not error out then but continue with only that one
family (assuming it's the same family as was requested here, "family" variable)

@@ +1895,3 @@
+        GSocketFamily family;
+
+        family = priv->is_ipv6 ? G_SOCKET_FAMILY_IPV6 : G_SOCKET_FAMILY_IPV4;

Same thing here as above, but also the family actually depends on what
multicast address is selected and available in the pool at all.

I don't think this is correct as is.


Also see https://bugzilla.gnome.org/show_bug.cgi?id=793441, there will have to
be multiple udpsinks in the end. One for each multicast destination, and
corresponding udpsrcs. Due to ports.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.