[Bug 796876] deinterlace: Closed caption pass-through

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796876

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373167|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373167:
 --> (https://bugzilla.gnome.org/review?bug=796876&attachment=373167)

::: gst/deinterlace/gstdeinterlace.c
@@ +810,3 @@
+      if (self->field_history[idx].caption->data) {
+        /* If it was passed to a frame, this is set to NULL */
+        g_free (self->field_history[idx].caption->data);

g_free() is NULL-safe

@@ +829,3 @@
+  gst_deinterlace_delete_meta_at (self, idx);
+
+  gst_video_frame_unmap_and_free (gst_deinterlace_pop_history (self));

For a later time (add a FIXME comment!) it would be good if pop_history() would
fill an out-parameter with the frame and everything else. Currently there's
pop_history() that works with the indizes and then you do it again manually a
few lines above here.

Also generally the history handling should be refactored a bit to have
meaningful functions instead of code arbitrarily adjusting the history in
similar ways in multiple places.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.