[Bug 796883] tagdemux: Properly propagate gst_pad_pull_range() errors

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jul 27 12:39:57 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796883

Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373186|none                        |accepted-commit_now
             status|                            |

--- Comment #2 from Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> ---
Review of attachment 373186:
 --> (https://bugzilla.gnome.org/review?bug=796883&attachment=373186)

Looks good.

::: gst-libs/gst/tag/gsttagdemux.c
@@ +1221,3 @@
   if (!have_tag) {
     GST_DEBUG_OBJECT (demux, "Could not find start tag");
+    flow_ret = GST_FLOW_OK;

Up to you, flow_ret could be initialize to OK by default.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list