[Bug 783521] gl: Add "direct" dmabuf uploader

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783521

--- Comment #36 from Michael Olbrich <m.olbrich at pengutronix.de> ---
(In reply to Matthew Waters (ystreet00) from comment #31)
> Review of attachment 372960 [details] [review]:
> @@ +1868,3 @@
>  
> +  if (ret == GST_GL_UPLOAD_RECONFIGURE && upload->priv->method_i > 0)
> +    upload->priv->saved_method_i = upload->priv->method_i - 1;
> 
> Any particular reason why this wasn't put into the above if statement with
> all the other ret checking?

The other ret checking is there to determine if we should stop looping. This
check should happen after the loop stopped.

> Also, this assumes that the first method will never need a reconfigure.

No, method_i points to the next method. I'll remove that check. method_i is
never 0 here. I added this at the time to make sure that 'method_i - 1' is not
negative.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.