[Bug 791674] Continued improvements to AOM plugin

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791674

--- Comment #52 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 373219:
 --> (https://bugzilla.gnome.org/review?bug=791674&attachment=373219)

::: ext/aom/gstav1enc.c
@@ +99,3 @@
+    {AOM_CBR, "cbr", "cbr"},
+    {AOM_CQ, "cq", "cq"},
+    {AOM_Q, "q", "q"},

The long form should be something human understandable (cq isn't for example).

@@ +245,3 @@
+      g_param_spec_uint ("drop-frame", "Drop frame",
+          "Temporal resampling configuration, Set to zero (0) to disable this
\
+          featrue.", 0, G_MAXUINT, DROP_FRAME_DEFAULT, G_PARAM_READWRITE |
G_PARAM_STATIC_STRINGS));

s/featrue/feature/ .. And it probably makes sense to add a little bit more
explanation of what this means.

@@ +795,3 @@
+    g_mutex_unlock (&av1enc->encoder_lock);
+    if (status != AOM_CODEC_OK) {
+      GST_ELEMENT_ERROR (av1enc, LIBRARY, INIT,

This should probably be a warning instead of an error, it's not fatal per-se.
And it's not INIT.. and I'm not sure it should be an message, mayube a simple
GST_WARNING_OBJECT() is enough.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.