[Bug 796842] srt: Refactor plugin to support non-blocking SRT APIs

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796842

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373213|none                        |needs-work
             status|                            |

--- Comment #47 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 373213:
 --> (https://bugzilla.gnome.org/review?bug=796842&attachment=373213)

::: ext/srt/gstsrtbasesrc.c
@@ +385,1 @@
+  /**

Any reason to switch from the property array to the other API?

@@ +393,3 @@
+          G_MAXINT32, DEFAULT_POLL_TIMEOUT,
+          G_PARAM_READWRITE | GST_PARAM_MUTABLE_READY |
+          G_PARAM_STATIC_STRINGS));

Why have a timeout on the polling at all? What would that gain us?

::: ext/srt/gstsrtclientsrc.c
@@ +248,1 @@
+  gst_element_class_set_metadata (element_class,

Same question here on why change the API away from the array one?

::: ext/srt/gstsrtclientsrc.h
@@ +44,2 @@
   /*< private >*/
+  GstSRTClientSrcPrivate *priv;

No point in having a separate private, the whole plugin's implementation is
private.

@@ +47,1 @@
   gpointer _gst_reserved[GST_PADDING];

We actually shouldn't have a reserved either

::: ext/srt/gstsrtserversrc.h
@@ +45,2 @@
   /*< private >*/
+  GstSRTServerSrcPrivate *priv;

Same here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.