[Bug 796842] srt: Refactor plugin to support non-blocking SRT APIs

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796842

--- Comment #53 from Seungha Yang <pudding8757 at gmail.com> ---
(In reply to Seungha Yang from comment #51)
> (In reply to Olivier Crête from comment #50)
> > Review of attachment 373213 [details] [review] [review]:
> > 
> > ::: ext/srt/gstsrtbasesrc.c
> > @@ +212,3 @@
> > +  /* HACK: Since srt_epoll_wait() is not cancellable, install our event fd
> > to
> > +   * epoll */
> > +  srt_epoll_add_ssock (self->poll_id, self->event_fd, NULL);
> > 
> > With this, we don't need the poll-timeout anymore. I think we can just poll
> > forever and use the cancellation with our own socket to unblock it.
> 
> I agree. Now "poll-timeout" is useless anymore. I'll remove "poll-timeout"
> from source/sink

Oh, the "poll-timeout" property was exposed in 1.14. I think we shouldn't
remove it but it needs to be specified as deprecated instead. Is it correct?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.