[Bug 796898] pad: Update pad offsets on the current event if the offset changed in pad probes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796898

Jan Schmidt <thaytan at noraisin.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373226|none                        |needs-work
             status|                            |

--- Comment #4 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 373226:
 --> (https://bugzilla.gnome.org/review?bug=796898&attachment=373226)

Looks OK, except for one thing

::: gst/gstpad.c
@@ +5633,3 @@
   GstPadEventFullFunction eventfullfunc = NULL;
   GstObject *parent;
+  gint64 old_pad_offset = pad->offset;

pad->offset is protected by the OBJECT_LOCK, that's not taken until the next
line?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.