[Bug 796480] qtdemux: Forward upstream time-format segment without mapping

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jun 1 15:39:44 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796480

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372512|none                        |needs-work
             status|                            |

--- Comment #8 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 372512:
 --> (https://bugzilla.gnome.org/review?bug=796480&attachment=372512)

This doesn't test so much, but ok.

BTW, we are working on precise segment check tests (in validate) for different
use cases.

::: tests/check/elements/qtdemux.c
@@ -36,1 +36,9 @@
-  GstBuffer *buf = GST_PAD_PROBE_INFO_BUFFER (info);
+  if (GST_IS_EVENT (GST_PAD_PROBE_INFO_DATA (info))) {
+    GstEvent *ev = GST_PAD_PROBE_INFO_EVENT (info);
+
... 6 more ...

Better use GST_CLOCK_TIME_IS_VALID.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list