[Bug 796490] New: GESTimelineElement has some collisions between virtual methods and invokers

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Jun 3 23:55:36 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796490

            Bug ID: 796490
           Summary: GESTimelineElement has some collisions between virtual
                    methods and invokers
    Classification: Platform
           Product: GStreamer
           Version: unspecified
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-editing-services
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: corentin at elementary.io
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

To make Vala happy, the invoker and virtual functions have to have to same
prototype.
Here for GESTimelineElement, a possible approach would be to add a `gboolean`
as return type of the invokers

The virtual methods:
```
  gboolean (*set_start)        (GESTimelineElement * self, GstClockTime start);
  gboolean (*set_inpoint)      (GESTimelineElement * self, GstClockTime
inpoint);
  gboolean (*set_duration)     (GESTimelineElement * self, GstClockTime
duration);
  gboolean (*set_max_duration) (GESTimelineElement * self, GstClockTime
maxduration);
  gboolean (*set_priority)     (GESTimelineElement * self, guint32 priority);
```
The invokers:
```
GES_API
void ges_timeline_element_set_start                  (GESTimelineElement *self,
GstClockTime start);
GES_API
void ges_timeline_element_set_inpoint                (GESTimelineElement *self,
GstClockTime inpoint);
GES_API
void ges_timeline_element_set_duration               (GESTimelineElement *self,
GstClockTime duration);
GES_API
void ges_timeline_element_set_max_duration           (GESTimelineElement *self,
GstClockTime maxduration);
GES_API
void ges_timeline_element_set_priority               (GESTimelineElement *self,
guint32 priority);
```

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list