[Bug 796491] CRITICAL assertion duration change when play audio files based on gstplayer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796491

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372536|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 372536:
 --> (https://bugzilla.gnome.org/review?bug=796491&attachment=372536)

::: gst-libs/gst/player/gstplayer.c
@@ +1701,2 @@
   if (gst_element_query_duration (self->playbin, GST_FORMAT_TIME, &duration))
{
+    if (self->cached_duration !=  duration)

There's a double-space here and in the other place before duration.

Also I meant putting this comparison inside emit_duration_changed() and just
doing an early return there instead of asserting :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.