[Bug 794306] vaapih264enc caps negotiation is broken by default

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Jun 5 08:21:50 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=794306

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372375|none                        |reviewed
             status|                            |

--- Comment #18 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 372375:
 --> (https://bugzilla.gnome.org/review?bug=794306&attachment=372375)

overall it looks good

::: gst/vaapi/gstvaapiencode_h264.c
@@ +326,3 @@
     }

     /* Check whether "stream-format" is avcC mode */

I wonder if we should use profile_caps to look for the avcC mode

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list