[Bug 796468] msdk: detail vpp has no expected effect

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796468

--- Comment #3 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Fei from comment #2)
> @Sree, If I remove vppdouse in ensure_filters, then the detail works. In my
> understanding, the vppdouse should include several filters with default
> value, if the value is not default, it may be get error.


According to msdk spec, there are two ways to enable filters:
1: Filters can be enabled by adding a filter ID
to mfxExtVPPDoUse. In this case, default filter parameters are used

2: Add filter configuration structures directly to mfxVideoParam.

Again: Using 1 with 2 is optional.

I chose 1 & 2 since I noticed a failure with closed source msdk sometime ago.
But I don't remember the scenario and I can't reproduce any issue with my
current test setup too.

Since the spec is indicating the usage of 1+2 as legal (optional), It is a bit
strange that mfxExtVPPDetail is not working as expected.
IMHO, Ideally, we should file a bug against msdk. Or at least should ask for
clarification: "What happens if we use 1&2? will it use default values or the
values provided in mfxVideoparm?"

Note: There was a mis-ordering of structure usage which I fixed with commit:   
 8c7a457669de948498ed64fe1a0f9bee07faed55. It is not a fix for the issue you
have raised.

BTW, if you can provide a patch to remove the VPPDoUse, I have no object to
push it :)
VPPDoUse could be useful in future to query the supported features, but that
should be a separate patch in a separate bug report.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.