[Bug 796505] [gstreamer-vaapi][jpegdec] decode image display nothing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796505

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372585|none                        |needs-work
             status|                            |

--- Comment #5 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 372585:
 --> (https://bugzilla.gnome.org/review?bug=796505&attachment=372585)

The commit message is wrong:

the patch is unrelated with vaapijpegdec, but with "libs: decoder: ..."

later, there is not a reason to do this change

does the spec say that?
does it make sense in general? 
is it safer?

::: gst-libs/gst/vaapi/gstvaapidecoder_objects.c
@@ +311,3 @@
+  for (i = 0; i < picture->slices->len; i++) {
+    GstVaapiSlice *const slice = g_ptr_array_index (picture->slices, i);
+    if (slice->param_id != VA_INVALID_ID) {

there  is no need to check if the param_id is not invalid, since
vaapi_destroy_buffer() already do it.

@@ +313,3 @@
+    if (slice->param_id != VA_INVALID_ID) {
+      vaapi_destroy_buffer (va_display, &slice->param_id);
+      slice->param_id = VA_INVALID_ID;

there is no need to set param_id to invalid since vaapi_destroy_buffer() do it
too

@@ +317,3 @@
+    if (slice->data_id != VA_INVALID_ID) {
+      vaapi_destroy_buffer (va_display, &slice->data_id);
+      slice->data_id = VA_INVALID_ID;

here the same too

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.