[Bug 796106] video: Support alternate interlaced video

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796106

Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372507|none                        |reviewed
             status|                            |

--- Comment #9 from Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> ---
Review of attachment 372507:
 --> (https://bugzilla.gnome.org/review?bug=796106&attachment=372507)

::: gst-libs/gst/video/video-frame.h
@@ +44,3 @@
+ * @GST_VIDEO_FRAME_FLAG_BF: The video frame has the bottom field only. This
is
+ *                           the same as GST_VIDEO_FRAME_FLAG_ONEFIELD
+ *                           (GST_VIDEO_FRAME_FLAG_TFF flag unset).

Missing Since marker.

@@ +58,3 @@
+  GST_VIDEO_FRAME_FLAG_TF           = GST_VIDEO_FRAME_FLAG_TFF |
+                                      GST_VIDEO_FRAME_FLAG_ONEFIELD,
+  GST_VIDEO_FRAME_FLAG_BF           = GST_VIDEO_FRAME_FLAG_ONEFIELD,

May I suggest naming these just _TOP and _BOTTOM ?

@@ +125,3 @@
 #define GST_VIDEO_FRAME_IS_ONEFIELD(f)    (GST_VIDEO_FRAME_FLAG_IS_SET(f,
GST_VIDEO_FRAME_FLAG_ONEFIELD))
+#define GST_VIDEO_FRAME_IS_TF(f)          (GST_VIDEO_FRAME_FLAG_IS_SET(f,
GST_VIDEO_FRAME_FLAG_TF))
+#define GST_VIDEO_FRAME_IS_BF(f)          (GST_VIDEO_FRAME_FLAG_IS_SET(f,
GST_VIDEO_FRAME_FLAG_BF))

Then IS_TOP, IS_BOTTOM.

@@ +174,3 @@
+ * @GST_VIDEO_BUFFER_FLAG_BF:          The video frame has the bottom field
only. This is
+ *                                     the same as
GST_VIDEO_BUFFER_FLAG_ONEFIELD
+ *                                     (GST_VIDEO_BUFFER_FLAG_TFF flag unset).

Same.

@@ +195,3 @@
+                                       GST_VIDEO_BUFFER_FLAG_ONEFIELD,
+  GST_VIDEO_BUFFER_FLAG_BF           = GST_VIDEO_BUFFER_FLAG_ONEFIELD,
+

Same.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.