[Bug 796516] kms: add support for kms atomic api

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796516

--- Comment #3 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 372577:
 --> (https://bugzilla.gnome.org/review?bug=796516&attachment=372577)

::: sys/kms/gstkmssink.c
@@ +117,3 @@

+static gint
+add_connector_property (GstKMSSinkPrivate * priv, drmModeAtomicReq * req,

I don't see this function being used.

@@ +140,3 @@
+static gint
+add_crtc_property (GstKMSSinkPrivate * priv, drmModeAtomicReq * req,
+    uint32_t obj_id, const gchar * name, uint64_t value)

ditto

@@ +146,3 @@
+
+  for (i = 0; i < priv->crtc.props->count_props; i++) {
+    if (strcmp (priv->crtc.props_info[i]->name, name) == 0) {

afaik, string comparison is expensive. Isn't other way to match these
properties?

@@ -1500,3 @@
-  if (!gst_kms_sink_sync (self)) {
-    GST_OBJECT_UNLOCK (self);
-    goto bail;

we should refactor this to enable both behavior: for non-atomic sync an the
atomic commit.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.