[Bug 796541] waylandsink: support video crop using viewporter protocol

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jun 8 12:21:32 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796541

Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372605|none                        |needs-work
             status|                            |

--- Comment #4 from Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> ---
Review of attachment 372605:
 --> (https://bugzilla.gnome.org/review?bug=796541&attachment=372605)

Ok, looks ok in general, please make a better commit message, and also update
propose_allocation() as right now, if you receive a crop meta on a buffer it
means up have a bug in your upstream element. Upstream element should only
attach crop meta if the allocation query contains GST_VIDEO_CROP_META_API_TYPE

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list