[Bug 796544] qtdemux: Add comment about qtdemux->segment

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jun 8 15:41:35 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796544

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372606|none                        |reviewed
             status|                            |

--- Comment #2 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 372606:
 --> (https://bugzilla.gnome.org/review?bug=796544&attachment=372606)

::: gst/isomp4/qtdemux.h
@@ -119,1 +119,8 @@
-  /* configured playback region */
+  /* Configured playback region.
+   *
+   * segment.format is always GST_FORMAT_TIME.
... 5 more ...

Sounds like somethings that might (likely?) get obsoleted.

@@ +153,3 @@
+   *
+   * qtdemux->segment is modified in response to seeks and when a TIME segment
+   * event is sent from upstream. In the latter case, the upstream segment is

s/is//

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list