[Bug 796516] kms: add support for kms atomic api

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jun 8 19:43:38 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796516

--- Comment #5 from Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> ---
Review of attachment 372604:
 --> (https://bugzilla.gnome.org/review?bug=796516&attachment=372604)

::: sys/kms/gstkmssink.c
@@ +75,3 @@
+
+#define fill_device_connector(self)                                     \
+        fill_drm_properties(self, conn, CONNECTOR)

I think it's better to use inline then macros. And I don't really like macros
that uses values from the upper context.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list