[Bug 796558] event: Unset SNAP flags when creating a new seek event without KEY_UNIT flag

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796558

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 372629
  --> https://bugzilla.gnome.org/attachment.cgi?id=372629
event: Unset SNAP flags when creating a new seek event without KEY_UNIT flag

>+  /* SNAP flags only make sense in combination with the KEYUNIT flag. Warn
>+   * and unset the SNAP flags if they're set without the KEYUNIT flag */
>+  if (!(flags & GST_SEEK_FLAG_KEY_UNIT) &&
>+      (flags & (GST_SEEK_FLAG_SNAP_BEFORE | GST_SEEK_FLAG_SNAP_AFTER |
>+              GST_SEEK_FLAG_SNAP_NEAREST))) {
>+    g_warn_if_fail ((flags & GST_SEEK_FLAG_KEY_UNIT)
>+        || !(flags & (GST_SEEK_FLAG_SNAP_BEFORE | GST_SEEK_FLAG_SNAP_AFTER |
>+                GST_SEEK_FLAG_SNAP_NEAREST)));

Should we maybe just do a g_warning() with some text here? :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.