[Bug 796559] qtdemux: Various segment fixes to properly take segment.offset into account

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796559

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Sebastian Dröge (slomo) from comment #3)
> Review of attachment 372633 [details] [review]:
> 
> ::: gst/isomp4/qtdemux.c
> @@ +4897,3 @@
>    stream->segment.applied_rate = qtdemux->segment.applied_rate;
>    stream->segment.rate = rate;
>    stream->segment.start = start + QTSTREAMTIME_TO_GSTTIME (stream,
> 
> In theory, segment.time should be gst_segment_to_stream_time(offset) here
> and we would not have to calculate it.

Actually no, it must be stream time of offset forwards (that's exactly what it
does now), or backwards the stream time of demux->segment.start (aka
demux->segment.time), which it also does already (except for some weird special
case that makes no sense to me).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.