[Bug 796539] vaapiencoder: (baseclass): wrap in a while loop g_cond_wait() as documented
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Mon Jun 11 11:59:35 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=796539
--- Comment #4 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Nicolas Dufresne (ndufresne) from comment #3)
> Review of attachment 372603 [details] [review]:
>
> Ok, this isn't the right fix, but clearly a cond_wait without a condition
> loop is buggus. g_cond_wait() can unblock for no reason, you must wrap it up
> in a look that checks a condition. Is that still like this in 1.14+ ?
That code hasn't changed since. Thus, your patch looks promising. Would be
great if you do it for master and following the contributing rules:
https://gstreamer.freedesktop.org/documentation/contribute/index.html#patch-format
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list