[Bug 796493] kmssink: add support for GBM allocator

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796493

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372643|none                        |needs-work
             status|                            |

--- Comment #5 from Julien Isorce <julien.isorce at gmail.com> ---
Review of attachment 372643:
 --> (https://bugzilla.gnome.org/review?bug=796493&attachment=372643)

Thx for your contribution. I think this should go in the "existing" directory
gst-plugins-base/tree/gst-libs/gst/gl/gbm
It already contains gbm bits and I am sure your patch have some duplications
with this directory.
Please check and let us know if there is anything in your patch that is not in
this directory above. Thx!

::: sys/kms/gstgbmallocator.c
@@ +268,3 @@
+  h = GST_VIDEO_INFO_HEIGHT (vinfo);
+
+  /* TODO: add C8 fackback allocation */

s/fackback/fallback/g

@@ +301,3 @@
+  mem = GST_MEMORY_CAST (gbmmem);
+
+  /* TODO: add C8 fackback allocation */

Same

@@ +406,3 @@
+  gobject_class->finalize = gst_gbm_allocator_finalize;
+
+  g_props[PROP_DRM_FD] = g_param_spec_int ("drm-fd", "DRM fd",

Make it more clear this is a fd for the drm 'device'. Ideally you also add a
drm-device-path property.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.