[Bug 796559] qtdemux: Various segment fixes to properly take segment.offset into account

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796559

--- Comment #10 from Alicia Boya García <aboya at igalia.com> ---
(In reply to Sebastian Dröge (slomo) from comment #7)
> (In reply to Alicia Boya García from comment #6)
> > Review of attachment 372632 [details] [review] [review]:
> > 
> > ::: gst/isomp4/qtdemux.c
> > @@ +1566,3 @@
> > +  /* TODO: If !update we can keep all the streams at their current
> > +   * position and don't have to go through all the edst/segment finding
> > +   * machinary. We only need to send an updated segment in that case.
> > 
> > Isn't sending an updated segment required for all kinds of seeks?
> 
> Yes, "only" is the keyword here. Only a new segment is needed, not all the
> other stuff that is done to find the correct edst segment, and then finding
> the correct sample in there, etc.

I see... the wording is ambiguous so I would rephrase it as:

"In that case, we only need to send an updated segment."

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.